Added K8S 1.8-11.x and the missing -strict#8
Added K8S 1.8-11.x and the missing -strict#8consideRatio wants to merge 6 commits intogarethr:masterfrom
Conversation
|
@hiddeco thanks for paving the way, your PR functioned as documentation on how to contribute for me =D |
| openapi2jsonschema -o "${version}-standalone" --kubernetes --stand-alone "${schema}" | ||
| fi | ||
|
|
||
| if [ "${recreate}" = true ] || [ ! -d -o "${version}-local" ]; then |
There was a problem hiding this comment.
There is an extra -o here that is incorrect.
There was a problem hiding this comment.
Oh woops - I tested what would happen with this this mistake of including -o and realized that this means that whatever I ran with recreate=false with a non-existing ...-local directory were never created.
I'll make sure to fix this, and generate potentially missing ...-local directories.
# the empirical test I made to determine what adding -o caused
mkdir test
if [ ! -d -o "test" ]; then echo "1"; fi
if [ ! -d "test" ]; then echo "2"; fi
if [ ! -d -o "testNoExistance" ]; then echo "3"; fi
if [ ! -d "testNoExistance" ]; then echo "4"; fi
# output was "4" only
|
Thanks @willthames for reviewing the changes I made to the generation script. I had generated all the |
|
@consideRatio - yeah, I noticed because I wanted to generate |
|
Apologies for taking an age to get back to this, I've not had much time to maintain in a while unfortunately. I've done a bulk update of versions today, and have some plans afoot to move this into a standalone org and get more folks involved as maintainers. I'll ping when I have more details in case you might still be interested. |
3 participants
@garethr thank you for the work you have done with this and
kubeval! It made me catch a sneaky bug that took a long time to find. I hope to usekubevalwith an even more satisfactory feeling using these updates.This PR
v1.11.0v1.10.5v1.9.9v1.8.14-strictdirectoriesrecreate=falseinbuild.sh)