Upgrade `k8s.io/*` to `v0.35.0`, `sigs.k8s.io/controller-runtime` to `v0.23.1`, `sigs.k8s.io/controller-tools` to `v0.20.0` by timuthy · Pull Request #13982 · gardener/gardener

timuthy · 2026-02-06T13:54:21Z

How to categorize this PR?

/area open-source dev-productivity ops-productivity
/kind enhancement

What this PR does / why we need it:
Upgrades k8s.io/* to v0.35.0, sigs.k8s.io/controller-runtime to v0.23.1, sigs.k8s.io/controller-tools to v0.20.0.

Please see individual commits for more information.

Which issue(s) this PR fixes:
Fixes #13901

Special notes for your reviewer:

~~161e3c9 will be removed as soon as Re-add terminal-controller-manager Go dependency #13979 is merged~~
4ba170d was an outcome while working on the disablement of client-side throttling. Later, we decided to not disable client-side throttling in this PR, as is it requires more preparation and follow ups (priority and fairness config, feature gate, etc.). Still, I decided to keep the small refactoring in this PR.
433885f adds a new panel, here is a screenshot (timeouts are fabricated):

Release note:

The following dependencies are updated:
- `k8s.io/*`: `v0.34.3` -> `v0.35.0`
- `sigs.k8s.io/controller-runtime`: `v0.22.5` -> `v0.23.1`
- `sigs.k8s.io/controller-tools`: `v0.19.0` -> `v0.20.0`

The `controller-runtime/controller details` observability dashboard contains a new reconciliation timeout panel. This data can help to find premature eliminated reconciliation runs due to a context timeout.

timuthy · 2026-02-06T16:55:25Z

There seems to be race condition in the new event recorder, leading to a flaky integration test (test, failed test-run).
Deferring the event submission by a few milliseconds solves the flake.
However, I'm wondering why we have dedicated integration tests for this functionality which is not owned by us. @oliver-goetz can you give more details about the motivation?

rfranzke · 2026-02-09T10:24:22Z

/assign @rfranzke @oliver-goetz

rfranzke

Nice, well-done

/lgtm
apart from the flake issue

gardener-prow · 2026-02-09T11:14:28Z

LGTM label has been added.

Details

Git tree hash: 29bdc523ea213243b33540904dd61aae2cf3510c

oliver-goetz · 2026-02-09T14:30:35Z

There seems to be race condition in the new event recorder, leading to a flaky integration test (test, failed test-run). Deferring the event submission by a few milliseconds solves the flake. However, I'm wondering why we have dedicated integration tests for this functionality which is not owned by us. @oliver-goetz can you give more details about the motivation?

The integration test tests whether node-agent-authorizer grants GNA create and patch permissions for events.
Since GNA uses the event recorder, I used it here too.

The `OpenTelemetry-Operator` includes dependencies to an older version of `sigs.k8s.io/controller-runtime` which is incompatible with the version (v0.23) used in Gardener. Copying the API packages solves the dependency conflict for now. See open-telemetry/opentelemetry-operator#4667 for more information.

The generation needs to be adapted due to kubernetes/kube-openapi#563

Motivated by kubernetes-sigs/controller-runtime#3262

Add `ReconciliationTimeout` panel to the controller details dashboard. The uses the newly introduced `controller_runtime_reconcile_timeouts_total metric` metric (see kubernetes-sigs/controller-runtime#3382).

timuthy · 2026-02-11T21:47:13Z

/retest

Don't use the event recorder to test patch permissions. We've seen cases where the event recorder drops events if they are recorded too quickly.

rfranzke

/lgtm
/approve

gardener-prow · 2026-02-12T13:42:47Z

LGTM label has been added.

Details

Git tree hash: 1a620084f735b235833f6d260b260fe47ea7fcc4

gardener-prow · 2026-02-12T13:42:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [rfranzke]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gardener-prow · 2026-02-12T22:12:21Z

@timuthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-gardener-apidiff	`afde6c4`	link	false	`/test pull-gardener-apidiff`

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2026

gardener-prow bot assigned oliver-goetz and rfranzke Feb 9, 2026

rfranzke reviewed Feb 9, 2026

View reviewed changes

gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2026

timuthy added 7 commits February 11, 2026 14:03

make tidy && make generate

38554c2

Adapt to incompatible changes

056b589

Adapt OpenAPI generation

d1e3e0b

The generation needs to be adapted due to kubernetes/kube-openapi#563

Migrate to k8s.io/client-go/tools/events

1af137c

Motivated by kubernetes-sigs/controller-runtime#3262

Refactor: Remove obsolete rest.Config constructor

4ba170d

Add ReconciliationTimeout panel

433885f

Add `ReconciliationTimeout` panel to the controller details dashboard. The uses the newly introduced `controller_runtime_reconcile_timeouts_total metric` metric (see kubernetes-sigs/controller-runtime#3382).

timuthy force-pushed the dep/kubernetes-1.35 branch from 1975fa8 to 9dc256d Compare February 11, 2026 13:04

gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2026

gardener-prow bot requested review from oliver-goetz and rfranzke February 11, 2026 13:04

gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2026

Change NodeAgentAuthorizer integration test

afde6c4

Don't use the event recorder to test patch permissions. We've seen cases where the event recorder drops events if they are recorded too quickly.

timuthy force-pushed the dep/kubernetes-1.35 branch from 9dc256d to afde6c4 Compare February 12, 2026 13:23

rfranzke reviewed Feb 12, 2026

View reviewed changes

gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2026

gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2026

gardener-prow bot merged commit a751d65 into gardener:master Feb 13, 2026
17 of 18 checks passed

timuthy deleted the dep/kubernetes-1.35 branch February 13, 2026 08:30

timuthy mentioned this pull request Mar 3, 2026

Fix cache sync timeouts in gardener-resource-manager #14212

Merged

shafeeqes mentioned this pull request Mar 16, 2026

Add "events.k8s.io" API group in RBAC for events #14327

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade `k8s.io/*` to `v0.35.0`, `sigs.k8s.io/controller-runtime` to `v0.23.1`, `sigs.k8s.io/controller-tools` to `v0.20.0`#13982

Upgrade `k8s.io/*` to `v0.35.0`, `sigs.k8s.io/controller-runtime` to `v0.23.1`, `sigs.k8s.io/controller-tools` to `v0.20.0`#13982
gardener-prow[bot] merged 8 commits intogardener:masterfrom
timuthy:dep/kubernetes-1.35

timuthy commented Feb 6, 2026 •

edited

Loading

Uh oh!

timuthy commented Feb 6, 2026

Uh oh!

rfranzke commented Feb 9, 2026

Uh oh!

rfranzke left a comment

Uh oh!

gardener-prow bot commented Feb 9, 2026

Uh oh!

oliver-goetz commented Feb 9, 2026

Uh oh!

timuthy commented Feb 11, 2026

Uh oh!

rfranzke left a comment

Uh oh!

gardener-prow bot commented Feb 12, 2026

Uh oh!

gardener-prow bot commented Feb 12, 2026

Uh oh!

gardener-prow bot commented Feb 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

timuthy commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timuthy commented Feb 6, 2026

Uh oh!

rfranzke commented Feb 9, 2026

Uh oh!

rfranzke left a comment

Choose a reason for hiding this comment

Uh oh!

gardener-prow bot commented Feb 9, 2026

Uh oh!

oliver-goetz commented Feb 9, 2026

Uh oh!

timuthy commented Feb 11, 2026

Uh oh!

rfranzke left a comment

Choose a reason for hiding this comment

Uh oh!

gardener-prow bot commented Feb 12, 2026

Uh oh!

gardener-prow bot commented Feb 12, 2026

Uh oh!

gardener-prow bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

timuthy commented Feb 6, 2026 •

edited

Loading

gardener-prow bot commented Feb 12, 2026 •

edited

Loading