Skip to content

fix: scraper of unity versions#43

Merged
webbertakken merged 1 commit intomainfrom
fix-scraper
Dec 12, 2022
Merged

fix: scraper of unity versions#43
webbertakken merged 1 commit intomainfrom
fix-scraper

Conversation

@webbertakken
Copy link
Copy Markdown
Member

@webbertakken webbertakken commented Dec 10, 2022 •
edited
Loading

Changes

How to test:

Go to Unity Editor archive page and run this in your console:

document.querySelectorAll('.release-links div:first-child a[href]').forEach(link => console.log(link.href))

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@AndrewKahr
Copy link
Copy Markdown
Member

AndrewKahr commented Dec 10, 2022

Wondering if now would actually be a good time to switch to scraping via their artifact server rather than trying to scrape their front end which changes style.

The link for reference: https://symbolserver.unity3d.com/000Admin/history.txt

@webbertakken
Copy link
Copy Markdown
Member Author

webbertakken commented Dec 10, 2022 •
edited
Loading

Wondering if now would actually be a good time to switch to scraping via their artifact server rather than trying to scrape their front end which changes style.

The link for reference: https://symbolserver.unity3d.com/000Admin/history.txt

Great suggestion.
For now I'm pretty happy with the "proven to work" way as this is a relatively easy fix.

Note that one of the releases has missing mono.pdb from previous releases inside the version field.

cloudymax
cloudymax approved these changes Dec 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@cloudymax cloudymax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@webbertakken webbertakken merged commit 523da4e into main Dec 12, 2022
@webbertakken webbertakken deleted the fix-scraper branch December 12, 2022 14:02
@EddieCameron EddieCameron mentioned this pull request Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloudymax cloudymax cloudymax approved these changes

@davidmfinol davidmfinol Awaiting requested review from davidmfinol

@EricRibeiro EricRibeiro Awaiting requested review from EricRibeiro

@frostebite frostebite Awaiting requested review from frostebite

@GabLeRoux GabLeRoux Awaiting requested review from GabLeRoux

+1 more reviewer

@guidoarkesteijn guidoarkesteijn guidoarkesteijn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Images missing for Unity 2022.2.0f1 and 2022.1.24f1

4 participants

@webbertakken @AndrewKahr @guidoarkesteijn @cloudymax