Move ajv-keywords to dev dependencies and update ajv to version 6#57
Closed
realityking wants to merge 2 commits intogajus:masterfrom
realityking:ajv
Closed
Move ajv-keywords to dev dependencies and update ajv to version 6#57realityking wants to merge 2 commits intogajus:masterfrom realityking:ajv
realityking wants to merge 2 commits intogajus:masterfrom
realityking:ajv
Conversation
They are only used in tests.
Owner
Contributor
Author
|
Oh wow, that is well hidden. I've changed the PR to only move |
realityking
changed the title
Owner
|
|
Contributor
Author
|
A quick grep in src and list I couldn't find a reference to it. Are you sure? If you are I'll just drop the first commit from this PR. |
Owner
|
|
Contributor
Author
|
It's the other way around, |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since ajv is only used in tests it should be a dev dependency. While I'm at it, I also updated it to version 6.
I didn't migrate the schema to version 7, that might be considered a breaking change.