fix(CJS): provide CJS version of to-valid-identiifer#1584
Merged
brettz9 merged 1 commit intogajus:mainfrom Oct 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for providing a CJS (CommonJS) version of the to-valid-identifier dependency, which is an ESM-only package. The solution uses Rollup to bundle the ESM package into a CJS format during the build process.
- Introduces Rollup configuration to transpile
to-valid-identifierfrom ESM to CJS - Updates build script to generate and use the CJS bundle
- Removes
escape-string-regexpfrom the dependency rejection list
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rollup.config.js | New Rollup configuration to bundle to-valid-identifier as CJS |
| package.json | Adds Rollup dependencies and integrates bundling into build process |
| .ncurc.cjs | Removes outdated comment about escape-string-regexp conversion |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 61.1.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(CJS): provide CJS version of to-valid-identiifer; fixes #1583