fix(no-undefined-types): also allow globals defined on languageOptions (#1415)

brettz9 · web-flow · commit e9ff4c717378 · 2025-06-23T06:35:08.000+08:00
diff --git a/docs/rules/no-undefined-types.md b/docs/rules/no-undefined-types.md
@@ -939,6 +939,9 @@ export class Code {
 
     /** @type {AnotherGlobal.AnotherMethod} */
     static #test4
+
+    /** @type {AGlobal.AnotherMethod} */
+    static #test5
 }
 ````
 
diff --git a/src/rules/noUndefinedTypes.js b/src/rules/noUndefinedTypes.js
@@ -126,7 +126,7 @@ export default iterateJsdoc(({
       return (/^\s*globals/u).test(comment.value);
     }).flatMap((commentNode) => {
       return commentNode.value.replace(/^\s*globals/u, '').trim().split(/,\s*/u);
-    });
+    }).concat(Object.keys(context.languageOptions.globals ?? []));
 
   const typedefDeclarations = comments
     .flatMap((doc) => {
diff --git a/test/rules/assertions/noUndefinedTypes.js b/test/rules/assertions/noUndefinedTypes.js
@@ -1645,9 +1645,15 @@ export default /** @type {import('../index.js').TestCases} */ ({
 
             /** @type {AnotherGlobal.AnotherMethod} */
             static #test4
+
+            /** @type {AGlobal.AnotherMethod} */
+            static #test5
         }
       `,
       languageOptions: {
+        globals: {
+          AGlobal: 'readonly',
+        },
         parser: typescriptEslintParser,
       },
     },

Original file line number	Diff line number	Diff line change
`@@ -939,6 +939,9 @@ export class Code {`
`939`	`939`
`940`	`940`	`/** @type {AnotherGlobal.AnotherMethod} */`
`941`	`941`	`static #test4`
	`942`	`+`
	`943`	`+ /** @type {AGlobal.AnotherMethod} */`
	`944`	`+ static #test5`
`942`	`945`	`}`
`943`	`946`	````
`944`	`947`