[Request For Comments] fix: @flow flag does not need to be first comment#240
Merged
Merged
Conversation
Contributor
Author
|
ping @gajus |
|
thx ! Now I just need a new release :D |
Owner
|
The release is done automatically after the commit is merged. |
|
oh I see, thanks ! I didn't see any change to package.json, that's why I was confused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eslint-plugin-flowtyperules require that the// @flowcomment be the first line of a file.This is stricter than Flow requires (emphasis in original), which simply requires the comment appear before any code:
This PR updates
noTypesMissingFileAnnotationto allows a comment to appear before the@flowcomment.This likely has more implications for
requireValidFileAnnotation, however.