Catch and default#1
Merged
gadicc merged 1 commit intogadicc:cookiefrom May 18, 2017
Merged
Conversation
buzzcloudau
commented
May 18, 2017
buzzcloudau
commented
- Catch exception to prevent fatal error. ( Might not be required with updated dependencies )
- Default the symbol for the url ( prevent it getting the cookie for 'undefined' )
- Catch exception to prevent fatal error. ( Might not be required with updated dependencies ) - Default the symbol for the url ( prevent it getting the cookie for 'undefined' )
Author
|
If you still wanted the fatal error, you could rethrow it. But I was hitting a promise error (no catch) and wasn't able to see the real error. |
Owner
|
So fast, yay! Thanks! |
Owner
|
Yeah we'll look at all the error handling more closely before final submission but yeah definitely for now it's better to print the error. Can't believe I left out the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.