Skip to content

Commit 9ed1bd4

Browse files
authored
Only run the common local engine configurations in presubmit (flutter#195688)
`local_engine_builds` compiles all 38 local_engine.json configurations on every engine PR. Move the six debug unopt configurations people actually iterate with to `local_engine_common.json` and make `local_engine_builds` postsubmit-only. Unfortunately `linux/wasm_debug_unopt` is the longest build which is staying in presubmit, so it doesn't reduce the overall wall time of the builder since they run in parrallel. Presubmit bot hours saved per week, from the last 7 days: host | saved | share of all presubmit hours on that host -- | -- | -- Mac | 1,059 | 11.5% Linux | 448 | 3.3% Windows | 426 | 6.3% Fixes flutter#195645 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 3f19e89 commit 9ed1bd4

4 files changed

Lines changed: 193 additions & 174 deletions

File tree

‎engine/src/flutter/.ci.yaml‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,22 @@ targets:
5151
enabled_branches:
5252
- master
5353
recipe: engine_v2/engine_v2
54+
presubmit: false
5455
properties:
5556
config_name: local_engine
5657
# local_engine schedules a bunch of other builds, so it's likely to timeout waiting for those builds to run.
5758
timeout: 180
5859

60+
# The local engine configurations most contributors build, so run in presubmit.
61+
- name: Linux local_engine_builds_common
62+
enabled_branches:
63+
- master
64+
recipe: engine_v2/engine_v2
65+
bringup: true
66+
properties:
67+
config_name: local_engine_common
68+
timeout: 180
69+
5970
- name: Linux linux_android_emulator_tests
6071
enabled_branches:
6172
- master

‎engine/src/flutter/ci/builders/local_engine.json‎

Lines changed: 0 additions & 171 deletions
Original file line numberDiff line numberDiff line change
@@ -162,41 +162,6 @@
162162
}
163163
}
164164
},
165-
{
166-
"cas_archive": false,
167-
"drone_dimensions": [
168-
"os=Mac-15.7|Mac-26.6",
169-
"device_type=none"
170-
],
171-
"gclient_variables": {
172-
"download_android_deps": false,
173-
"use_rbe": true
174-
},
175-
"gn": [
176-
"--ios",
177-
"--simulator",
178-
"--simulator-cpu=arm64",
179-
"--runtime-mode",
180-
"debug",
181-
"--unoptimized",
182-
"--no-stripped",
183-
"--no-lto",
184-
"--xcode-symlinks",
185-
"--rbe",
186-
"--no-goma"
187-
],
188-
"name": "macos/ios_debug_sim_unopt_arm64",
189-
"description": "Builds an unoptimized debug mode engine that targets the arm64 iOS simulator from a macOS host.",
190-
"ninja": {
191-
"config": "ios_debug_sim_unopt_arm64",
192-
"targets": []
193-
},
194-
"properties": {
195-
"$flutter/osx_sdk": {
196-
"sdk_version": "17c52"
197-
}
198-
}
199-
},
200165
{
201166
"cas_archive": false,
202167
"drone_dimensions": [
@@ -281,33 +246,6 @@
281246
"targets": []
282247
}
283248
},
284-
{
285-
"cas_archive": false,
286-
"drone_dimensions": [
287-
"os=Linux",
288-
"device_type=none"
289-
],
290-
"gclient_variables": {
291-
"use_rbe": true
292-
},
293-
"gn": [
294-
"--runtime-mode",
295-
"debug",
296-
"--unoptimized",
297-
"--android",
298-
"--android-cpu=arm64",
299-
"--no-stripped",
300-
"--no-lto",
301-
"--rbe",
302-
"--no-goma"
303-
],
304-
"name": "linux/android_debug_unopt_arm64",
305-
"description": "Builds an unoptimized debug mode engine that targets 64-bit arm Android from a Linux host.",
306-
"ninja": {
307-
"config": "android_debug_unopt_arm64",
308-
"targets": []
309-
}
310-
},
311249
{
312250
"cas_archive": false,
313251
"drone_dimensions": [
@@ -626,38 +564,6 @@
626564
}
627565
}
628566
},
629-
{
630-
"cas_archive": false,
631-
"drone_dimensions": [
632-
"os=Mac-15.7|Mac-26.6",
633-
"device_type=none"
634-
],
635-
"gclient_variables": {
636-
"download_android_deps": false,
637-
"use_rbe": true
638-
},
639-
"gn": [
640-
"--runtime-mode",
641-
"debug",
642-
"--unopt",
643-
"--mac-cpu",
644-
"arm64",
645-
"--xcode-symlinks",
646-
"--rbe",
647-
"--no-goma"
648-
],
649-
"name": "macos/host_debug_unopt_arm64",
650-
"description": "Builds a debug mode engine for a macOS host on arm64.",
651-
"ninja": {
652-
"config": "host_debug_unopt_arm64",
653-
"targets": []
654-
},
655-
"properties": {
656-
"$flutter/osx_sdk": {
657-
"sdk_version": "17c52"
658-
}
659-
}
660-
},
661567
{
662568
"cas_archive": false,
663569
"drone_dimensions": [
@@ -747,32 +653,6 @@
747653
"targets": []
748654
}
749655
},
750-
{
751-
"cas_archive": false,
752-
"drone_dimensions": [
753-
"os=Linux",
754-
"device_type=none"
755-
],
756-
"gclient_variables": {
757-
"download_android_deps": false,
758-
"use_rbe": true
759-
},
760-
"gn": [
761-
"--runtime-mode",
762-
"debug",
763-
"--unoptimized",
764-
"--no-stripped",
765-
"--no-lto",
766-
"--rbe",
767-
"--no-goma"
768-
],
769-
"name": "linux/host_debug_unopt",
770-
"description": "Builds an unoptimized debug mode engine for a Linux host.",
771-
"ninja": {
772-
"config": "host_debug_unopt",
773-
"targets": []
774-
}
775-
},
776656
{
777657
"cas_archive": false,
778658
"drone_dimensions": [
@@ -798,32 +678,6 @@
798678
"targets": []
799679
}
800680
},
801-
{
802-
"cas_archive": false,
803-
"drone_dimensions": [
804-
"os=Windows-10",
805-
"device_type=none"
806-
],
807-
"gclient_variables": {
808-
"download_android_deps": false,
809-
"use_rbe": true
810-
},
811-
"gn": [
812-
"--runtime-mode",
813-
"debug",
814-
"--unoptimized",
815-
"--no-stripped",
816-
"--no-lto",
817-
"--rbe",
818-
"--no-goma"
819-
],
820-
"name": "windows/host_debug_unopt",
821-
"description": "Builds an unoptimized debug mode engine for a Windows host.",
822-
"ninja": {
823-
"config": "host_debug_unopt",
824-
"targets": []
825-
}
826-
},
827681
{
828682
"cas_archive": false,
829683
"drone_dimensions": [
@@ -1012,31 +866,6 @@
1012866
},
1013867
"cas_archive": false
1014868
},
1015-
{
1016-
"name": "linux/wasm_debug_unopt",
1017-
"drone_dimensions": [
1018-
"device_type=none",
1019-
"os=Linux"
1020-
],
1021-
"gclient_variables": {
1022-
"download_android_deps": false,
1023-
"download_emsdk": true
1024-
},
1025-
"gn": [
1026-
"--web",
1027-
"--runtime-mode=debug",
1028-
"--unoptimized",
1029-
"--no-rbe",
1030-
"--no-goma"
1031-
],
1032-
"ninja": {
1033-
"config": "wasm_debug_unopt",
1034-
"targets": [
1035-
"flutter/web_sdk:flutter_web_sdk_archive"
1036-
]
1037-
},
1038-
"cas_archive": false
1039-
},
1040869
{
1041870
"name": "macos/wasm_release",
1042871
"drone_dimensions": [

0 commit comments

Comments
 (0)