fix: update to_string_view function for fmt 11.1#3301
Merged
gabime merged 1 commit intogabime:v1.xfrom Dec 26, 2024
Merged
Conversation
Signed-off-by: Rui Chen <[email protected]>
|
Tested - working 👍 |
Contributor
Owner
|
Thanks @chenrui333 |
|
👍🏻 waiting for new release ... |
Contributor
|
The new code for fmt >= 11.1.0 in this PR is dead...no reason to have a The new |
Owner
|
@chenrui333 Not sure i understand. It clearly fixed the problem with 11.1.0 |
Contributor
It's dead code. You can just make it a #ifndef and remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update
to_string_viewfunction for fmt 11.1relates to Homebrew/homebrew-core#202442