Add missing xchar.h header for fmt > 11.0.2#3274
Closed
ahoarau wants to merge 1 commit intogabime:v1.xfrom
Closed
Conversation
using fmt main branch, after the 11.0.2 release, `fmt::basic_format_string` is defined in `xchar.h`.
Otherwise compile error:
```
spdlog/common.h:369:49: error: no template named 'basic_format_string' in namespace 'fmt'; did you mean 'std::basic_format_string'?
[build] 369 | inline fmt::basic_string_view<T> to_string_view(fmt::basic_format_string<T, Args...> fmt) {
[build] | ^~~~~
[build] /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/format:128:12: note: 'std::basic_format_string' declared here
[build] 128 | struct basic_format_string
[build] | ^
[build] 1 error generated.
```
Owner
|
Something is wrong. It is already defined here spdlog/include/spdlog/fmt/xchar.h Line 21 in 951c5b9 |
Author
|
@gabime I just saw that.. Not the right patch for the issue. Investiguating. |
This was referenced Nov 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using fmt main branch, after the 11.0.2 release,
fmt::basic_format_stringis defined inxchar.h.Otherwise compile error: