Repository navigation
Commit 0385d6e
committed
[Impeller] Cover color attachment loads in the Vulkan render pass incoming dependency
A color attachment with LoadAction::kLoad is read by its loadOp at
COLOR_ATTACHMENT_OUTPUT with COLOR_ATTACHMENT_READ access. The incoming
VK_SUBPASS_EXTERNAL dependency only listed COLOR_ATTACHMENT_WRITE in its
dstAccessMask, so the layout transition and earlier writes weren't made
visible to the load. Add COLOR_ATTACHMENT_READ to the destination scope.
Adds Play/RendererTest.CachesRenderPassAndFramebufferMixed/Vulkan to the
Vulkan sync validation shard.
Fixes flutter#1956961 parent 287ec89 commit 0385d6e
2 files changed
Lines changed: 6 additions & 1 deletion
File tree
- engine/src/flutter
- impeller/renderer/backend/vulkan
- testing
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
204 | | - | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
205 | 209 | | |
206 | 210 | | |
207 | 211 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
227 | 227 | | |
228 | 228 | | |
229 | 229 | | |
| 230 | + | |
230 | 231 | | |
231 | 232 | | |
232 | 233 | | |
| |||
0 commit comments