Skip to content

Commit 453cb46

Browse files
bkonyiloic-sharma
andauthored
[flutter_tools] Implement Templates slice and flutter create integration (flutter#191748)
## Description This PR implements Step 5 of Flutter Tools Extensibility: the Templates extension slice and `flutter create` dynamic template integration. ### Architectural Overview 1. **`package:flutter_tools_core`**: - Defines core, platform-agnostic template models: `ProjectTemplate` and `ExtensionProjectTemplate` with JSON serialization, equality, and unordered set hashing. 2. **`package:flutter_tools_extension`**: - Defines the `TemplateService` RPC interface and handlers for `template.getAppTemplates`, `template.getPluginTemplates`, `template.getProjectTemplates`, and `template.generateTemplateParameters`. 3. **`package:flutter_tools_extension_linux_prototype`**: - Implements `LinuxTemplateService` and `LinuxProjectTemplate` declaring custom template `'custom-linux-app'` with `templateDependencies: {'app'}`. - Adds prototype template assets for `'custom-linux-app'`. 4. **`packages/flutter_tools`**: - Implements `ExtensionTemplateManager` to discover custom templates over RPC concurrently, cache them, resolve directories, and delegate parameter generation. - Updates `Template.fromDirectories` to merge directory sources over base template dependencies. - Integrates dynamic `--template` CLI options and help text into `CreateCommand` using `ExtensionArgParserMixin`. - Supports `ExtensionProjectTemplateType` in `FlutterProjectMetadata` and `ParsedFlutterTemplateType`. - Wires `ExtensionTemplateManager` through `executable.dart` into `CreateCommand`. ## Related Issues Part of flutter#190692 ## Tests - Added `packages/flutter_tools/packages/flutter_tools_core/test/templates_test.dart` - Added `packages/flutter_tools/packages/flutter_tools_extension_linux_prototype/test/linux_template_test.dart` - Added `packages/flutter_tools/test/general.shard/extension_protocol/template_service_test.dart` - Updated `packages/flutter_tools/test/general.shard/flutter_project_metadata_test.dart` - Updated `packages/flutter_tools/test/integration.shard/tool_extensions_test.dart` --------- Co-authored-by: Loïc Sharma <[email protected]>
1 parent b7362ab commit 453cb46

22 files changed

Lines changed: 1381 additions & 115 deletions

File tree

‎packages/flutter_tools/lib/executable.dart‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ import 'src/context/tool_dependencies.dart';
5353
import 'src/devtools_launcher.dart';
5454
import 'src/experimental/extension_discovery.dart';
5555
import 'src/experimental/extension_manager.dart';
56+
import 'src/experimental/templates.dart';
5657
import 'src/features.dart';
5758
import 'src/globals.dart' as globals;
5859
// Files in `isolated` are intentionally excluded from google3 tooling.
@@ -117,11 +118,18 @@ Future<void> main(List<String> args) async {
117118
entryPoints: <ExtensionEntryPoint>[linuxExtensionEntryPoint],
118119
featureFlags: featureFlags,
119120
);
121+
final templateManager = ExtensionTemplateManager(
122+
extensionManager: manager,
123+
fileSystem: toolDependencies.toolContext.fs,
124+
logger: toolDependencies.toolContext.logger,
125+
featureFlags: featureFlags,
126+
);
120127
return generateCommands(
121128
toolDependencies: toolDependencies,
122129
verboseHelp: verboseHelp,
123130
verbose: verbose,
124131
extensionManager: manager,
132+
extensionTemplateManager: templateManager,
125133
);
126134
},
127135
verbose: verbose,
@@ -225,6 +233,7 @@ List<FlutterCommand> generateCommands({
225233
required bool verbose,
226234
required bool verboseHelp,
227235
ExtensionManager? extensionManager,
236+
ExtensionTemplateManager? extensionTemplateManager,
228237
}) => <FlutterCommand>[
229238
AnalyzeCommand(
230239
verboseHelp: verboseHelp,
@@ -301,7 +310,7 @@ List<FlutterCommand> generateCommands({
301310
fileSystem: toolDependencies.toolContext.fs,
302311
logger: toolDependencies.toolContext.logger,
303312
),
304-
CreateCommand(verboseHelp: verboseHelp),
313+
CreateCommand(verboseHelp: verboseHelp, extensionTemplateManager: extensionTemplateManager),
305314
DaemonCommand(hidden: !verboseHelp),
306315
DebugAdapterCommand(verboseHelp: verboseHelp),
307316
DevicesCommand(verboseHelp: verboseHelp),

0 commit comments

Comments
 (0)