Fix "Unknown downloader type: npm-signature" exception #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR, but can you use the tool php-cs-fixer to respect the code style? I still have to add the doc for contributions.
|
|
Well, cs-fixer fixed unrelated cs violations... |
|
Ok, new rules have been introduced since the last commit. Can you keep only the code fixing the bug for this PR, and if you wish, propose another PR for the CS? Otherwise I will do this last.... I could quickly merge your PRs. Thank you. |
Dist entry resolution is now restricted to downloader types known by composer. Effectively this means that composer-asset-plugin will skip all dist entries that link to custom vendor protocol implementations, e.g. npm-signature. Fixes #321
|
@hypeJunction Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dist entry resolution is now restricted to downloader types
known by composer. Effectively this means that composer-asset-plugin
will skip all dist entries that link to custom vendor protocol
implementations, e.g. npm-signature.
Fixes #321
Replaces #323