Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not parse version constraint >=N.x. SemverConterter doesn't support wildcards in first part of range #253

Closed
lexeo opened this issue Sep 6, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@lexeo
Copy link

lexeo commented Sep 6, 2016

Same issue like #244 . I tried to install some package from private repository.
It requires angular-ui/angular-google-maps.
But in bower.json file of angular-google-maps package we can see:

"dependencies": {
    ...
    "lodash": "3.X - 4.X",
    ...
}

and that is why I got the error:
Could not parse version constraint >=3.x: Invalid version string "3.x".

So I ran Fxp\Composer\AssetPlugin\Tests\Converter\SemverConverterTest and provided one more example in data-provider method.
I expected that '3.x - 4.x' would be converted to '>=3.0,<5.0', but it didn't:

Failed asserting that two strings are equal.
Expected :'>=3.0,<5.0'
Actual :'>=3.x,<5.0'

Why does SemverConverter replace only second part of the range "3.x - 4.x" ?

@francoispluchino francoispluchino added this to the 1.3.0 milestone Feb 15, 2017
@francoispluchino francoispluchino self-assigned this Feb 15, 2017
@francoispluchino
Copy link
Member

Fixed by 4c176fb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants