Conversation
| pkg install -y libtasn1 | ||
| pkg upgrade -y libtasn1 | ||
| cd /usr | ||
| git clone https://github.com/3mdeb/freebsd-ports.git --depth 1 -b fwupd-port ports |
There was a problem hiding this comment.
A few comments I notice about this:
- It seems like
sysutils/fwupd/files/patch-libfwupd_meson.buildshould be submitted to apply upstream. The other ones too for#ifdefshould each be reviewed too. DISTVERSIONI doubt you want to hardcode. For the purpose of CI you should probably be passing this in as an environment variable or withsedor something.- Overall I think it would be more flexible if we could keep an "upstream" copy of this BSD Makefile in the fwupd tree and you regularly sync it with the downstream tree. Otherwise we may end up with a situation that we break the BSD build by hard bumping some dep but not being able to get the downstream BSD Makefile updated. If we can keep it (or a template of it) upstream then we can just submit the changes to make sure CI keeps working for BSD..
There was a problem hiding this comment.
- @Asiderr was the patch finally merged into fwupd/fwupd? By my understanding, the patches were for development purposes and now should be upstreamed.
- I will update that to use current tag as DISTVERSION
- My idea was that the CI would use the official freebsd-ports set to specific release (eg. 2020Q4) which would be updated manually. @Asiderr is working on upstreaming fwupd Makefile to freebsd/freebsd-ports and AFAIK it should be done soon.
| branches: [ master, 1_4_X, wip_bsd_ci ] | ||
| pull_request: | ||
| branches: [ master, 1_4_X ] | ||
| branches: [ master, 1_4_X, wip_bsd_ci ] |
There was a problem hiding this comment.
obviously this is for POC, and after you've got it working this goes away and we only do it on master.
| run: ./contrib/ci/generate_dependencies.py | sudo xargs apt install -y | ||
| - name: Check ABI | ||
| run: ./contrib/ci/check-abi $(git describe --abbrev=0 --tags) $(git rev-parse HEAD) | ||
| # abi: |
There was a problem hiding this comment.
also, obviously we wouldn't turn off other Github actions jobs.
|
@pkonkol is this somethingyou still want upstream? There's quite some work to do :) |
| pkg install -y libtasn1 | ||
| pkg upgrade -y libtasn1 | ||
| cd /usr | ||
| git clone https://github.com/3mdeb/freebsd-ports.git --depth 1 -b fwupd-port ports |
There was a problem hiding this comment.
@superm1 @hughsie @SergiiDmytruk We should push this forward in the near future. More and more FreeBSD-related changes are coming to fwupd, so a proper CI would be really useful. The upstream of the fwupd port will take some more time, so at the start we should base CI on the freebsd-ports fork, which will contain the fwupd package.
The FreeBSD related patches are already merged in the fwupd, so this PR needs significant changes. I will address this in the coming days.
There was a problem hiding this comment.
@Asiderr can you create a wip/freebsd branch on the upstream fwupd repo please, and then we can all just commit fixes on before we squash everything up for commit. If you just add the freesbd CI job there we can see what's left to upstream.
4 participants
Type of pull request: