build: Install bash-completion relative to datadir#2014
Merged
superm1 merged 1 commit intofwupd:masterfrom Apr 16, 2020
Merged
Conversation
Since bash-completion 2.9, it was no longer possible to override the completionsdir through prefix. [1] In 2.10, the overridability was re-estabilished but this time through datadir variable. [2] This should not really matter except for developers installing the project into a custom prefix or distros using per-package prefixes like NixOS. [1]: scop/bash-completion@81ba2c7 [2]: scop/bash-completion#344
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of pull request:
Since bash-completion 2.9, it was no longer possible to override
the
completionsdirthrough prefix. 1 In 2.10, the overridabilitywas re-estabilished but this time through
datadirvariable. 2This should not really matter except for developers installing the project
into a custom prefix or distros using per-package prefixes like NixOS.
Tested on NixOS with bash-completion 2.9 with the offending patch 1 reverted and with 2.10.