fix: patch handleHotUpdate properly#2903
Merged
fwouts merged 1 commit intofwouts:mainfrom Jun 3, 2025
Merged
Conversation
|
|
sapphi-red
changed the title
handleHotUpdate properly
Owner
|
Thank you @sapphi-red. This project isn't actively maintained at the moment, so you can remove it from the ecosystem-ci checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the current patch code works fine as
thisisundefinedfor current Vite, Vite 7+ will pass the context (vitejs/vite#19936) and the current code doesn't work anymore.This PR changes the code to call the hook function with the original
this.This PR should fix the ecosystem-ci failure.
https://github.com/vitejs/vite-ecosystem-ci/actions/runs/15291891294/job/43012757742#step:8:3335