Suggest alternatives for typoed rule attribute names

fmeum · copybara-github · commit 745ca2887702 · 2023-03-22T13:54:59.000-07:00
Closes bazelbuild#17847. PiperOrigin-RevId: 518664847 Change-Id: I99d09be093e785c7d1ad437d40866423638be118
diff --git a/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java b/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java
@@ -78,6 +78,7 @@
 import net.starlark.java.eval.Starlark;
 import net.starlark.java.eval.StarlarkCallable;
 import net.starlark.java.eval.StarlarkThread;
+import net.starlark.java.spelling.SpellChecker;
 import net.starlark.java.syntax.Location;
 
 /**
@@ -2080,7 +2081,16 @@ private <T> BitSet populateDefinedRuleAttributeValues(
       if (attrIndex == null) {
         rule.reportError(
             String.format(
-                "%s: no such attribute '%s' in '%s' rule", rule.getLabel(), attributeName, name),
+                "%s: no such attribute '%s' in '%s' rule%s",
+                rule.getLabel(),
+                attributeName,
+                name,
+                SpellChecker.didYouMean(
+                    attributeName,
+                    rule.getAttributes().stream()
+                        .filter(Attribute::isDocumented)
+                        .map(Attribute::getName)
+                        .collect(ImmutableList.toImmutableList()))),
             eventHandler);
         continue;
       }
