Skip to content

Commit 4b4e6f7

Browse files
yyltsamuelkarp
authored andcommitted
not set sandbox id when use podsandbox type
Signed-off-by: yang yang <[email protected]>
1 parent a501a43 commit 4b4e6f7

3 files changed

Lines changed: 9 additions & 2 deletions

File tree

internal/cri/server/container_create.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ import (
3232
cio "github.com/containerd/containerd/v2/internal/cri/io"
3333
crilabels "github.com/containerd/containerd/v2/internal/cri/labels"
3434
customopts "github.com/containerd/containerd/v2/internal/cri/opts"
35+
podsandboxtypes "github.com/containerd/containerd/v2/internal/cri/server/podsandbox/types"
3536
containerstore "github.com/containerd/containerd/v2/internal/cri/store/container"
3637
"github.com/containerd/containerd/v2/internal/cri/store/sandbox"
3738
"github.com/containerd/containerd/v2/internal/cri/util"
@@ -409,7 +410,9 @@ func (c *criService) createContainer(r *createContainerRequest) (_ string, retEr
409410
containerd.WithContainerExtension(crilabels.ContainerMetadataExtension, r.meta),
410411
)
411412

412-
opts = append(opts, containerd.WithSandbox(r.sandboxID))
413+
if r.sandbox.Sandboxer != podsandboxtypes.InternalSandboxID {
414+
opts = append(opts, containerd.WithSandbox(r.sandboxID))
415+
}
413416

414417
opts = append(opts, c.nri.WithContainerAdjustment())
415418
defer func() {

internal/cri/server/podsandbox/controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ import (
4747
func init() {
4848
registry.Register(&plugin.Registration{
4949
Type: plugins.PodSandboxPlugin,
50-
ID: "podsandbox",
50+
ID: types.InternalSandboxID,
5151
Requires: []plugin.Type{
5252
plugins.EventPlugin,
5353
plugins.LeasePlugin,

internal/cri/server/podsandbox/types/podsandbox.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ import (
2626
sandboxstore "github.com/containerd/containerd/v2/internal/cri/store/sandbox"
2727
)
2828

29+
const (
30+
InternalSandboxID = "podsandbox"
31+
)
32+
2933
type PodSandbox struct {
3034
ID string
3135
Container containerd.Container

0 commit comments

Comments
 (0)