Fix genTargetCmd function to deal with multiple and single selections#32
Merged
orangekame3 merged 3 commits intofuture-architect:mainfrom Dec 24, 2024
Merged
Conversation
Previous code only managed well single selection, multiple caused error modified: cmd/util.go
Collaborator
|
@jmonfar |
Collaborator
Contributor
Author
|
PR #1 touched the same file, so it did override my proposed change. Resolved. |
orangekame3
reviewed
Dec 23, 2024
Co-authored-by: Takafumi Miyanaga <[email protected]>
orangekame3
approved these changes
Dec 24, 2024
Merged
Collaborator
|
Thanks @jmonfar 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code only managed well single selection, multiple selection caused error.
The fix applies and correct this for apply, plan & destroy without affecting to any other feature.
It fixes also #12