Repository navigation
chore: merge main into dev (install failures fail the check, time limits, pipefail) - #279
Merged
Merged
Conversation
… (TH-8682) A failed install now fails the check whether or not the package is on the known-broken list. The install steps lose continue-on-error, so a failed install fails its own step and the package's tests do not run on a broken environment; the known-broken verdict also fails on any failed install, instead of warning. Every job gets a timeout-minutes (Plan 10, fi_instrumentation 30, package 45, result 5; the slowest job seen takes about a minute), and the PR-base fetch is limited to 120 s, falling back to running every package. The planner's tests pin each of these. A docstring fix in fi_instrumentation's context_attributes.py also makes this PR's CI install the repo's core into all 49 packages, proving that path once. Signed-off-by: khushalsonawat <[email protected]>
Signed-off-by: khushalsonawat <[email protected]>
…TH-8682) The workflow now sets defaults.run.shell to bash, so GitHub runs every step as bash -eo pipefail: a failed install piped through tee fails the step. The planner's tests pin that default and allow no other shell. The install steps' tests now pin each script command by command, its if:, and no continue-on-error, ||, pipe, set + or shell override, so a wrapper that swallows a failed install (|| :, if !, | tee, trap, a function or bash -c) fails the suite. The Tests step must have no if:, so it never runs after a failed install. Every job found under jobs: must have a job-level time limit. Signed-off-by: khushalsonawat <[email protected]>
ci: a failed install fails the check, and every job gets a time limit (TH-8682)
atharva-bhange
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Brings
devup to date withmainagain, sodev's Python tests check gets the rules from #278 before it is made required ondev:defaults: run: shell: bash).devhas no changes of its own: it is one merge commit (#277) ahead ofmain, with the same files asmainbefore #278. So this merges cleanly and brings exactly #278's six files. Please merge it with a merge commit (not squash or rebase), sodevandmainkeep one history.Why?
#277 gave
devthe workflow, but #278 merged intomainafter it. Without this,dev's check runs the older rules.Linear: TH-8682 (follow-up to TH-8673).
How was it tested?
python/fi_instrumentation/, so it tests all 49 packages, each with this repo'sfi_instrumentationinstalled, plus fi_instrumentation's own tests.main: run 39298772017, 52 of 52.🤖 Generated with Claude Code