Repository navigation
fix(truefoundry): reject incomplete streamed answers - #1093
Merged
Merged
Conversation
Co-Authored-By: Claude Code <[email protected]>
Limit ERROR status guidance to instrumented SDK and transport failures. Explain that application completeness validation cannot change the finished OK span with the existing published pins. Exercise the real entry point and loopback OTLP for all stream endings while retaining output, closure, flush and shutdown assertions. Co-Authored-By: Claude Code <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on merged #1069. The normal TrueFoundry streaming application now refuses to print an incomplete answer as a successful result.
finish_reason="stop"; EOF,[DONE], empty/usage-only endings, token limits and content filtering do not count as a complete answer.main()returns 1 with no partial answer on stdout when completion validation fails.Verification
main()truncation/completion probes pass at both SDK bounds.Release dependency
This fixes application behavior without waiting for a package release. The separate span-status/cancellation/privacy fixes remain in future-agi/traceAI#520 and future-agi/traceAI#536. The public registry still reports traceai-openai 0.1.12 and fi-instrumentation-otel 1.2.2, without those fixes. Existing recipe pins are intentionally unchanged: update them to genuine fixed releases when available, not invented versions. This PR is not a claim that the entire released telemetry recall is complete.
E2E coverage
The real SDK application entry point, mock HTTP transport, exit status/stdout, stream closure and existing loopback OTLP recipe tests are exercised; no application UI or e2e harness is changed.
Generated with Claude Code