Skip to content

Commit a6b52f1

Browse files
nik13claude
andcommitted
fix(claude-cowork): review fixes: MCP/skill names, reject pairing, retries, dedupe, HTTP front (TH-8296)
- Name MCP tool spans mcp__<server>__<tool> from tool_parameters; read only mcp_server_name, mcp_tool_name, skill_name and subagent_type from it, and drop a value that looks like a path or email. Fixture now uses tool_name "mcp_tool" as Anthropic documents for user-configured MCP servers. - Pair tool_result with tool_decision by tool_use_id, else by name and decision value, so a rejected call survives a retried accepted one. - Mark the prompt ERROR only when its last model request failed; a retried 429/529 stays ERROR on its own span. - api_error status message is "HTTP <code> <anthropic error type>" by default; the API's free text needs FI_BRIDGE_CAPTURE_CONTENT=1. - Skip identical re-delivered records; compute prompt totals and tool count from the deduped children. - Copy session.id, gen_ai.conversation.id and user.id to every span. - Map only service.name=cowork (FI_BRIDGE_ACCEPT_ANY_SERVICE=1 for tests); pass the incoming service.name through. - HTTP: check token and path before reading the body, 411 without a length, 413 over 16 MB, chunked and gzip bodies, 30 s socket timeout, log rejected requests once per status per minute. - Require FI_BRIDGE_TOKEN always (FI_BRIDGE_ALLOW_NO_TOKEN=1 for local tests); page keeps the loopback listen behind the reverse proxy. - Let an in-flight send finish on shutdown; tolerate non-numeric event.sequence; run_e2e.sh accepts a fractional idle time and cleans up. - Page: what is captured, privacy table, not-available and troubleshooting (404/411/413/415, ignored service) match the code. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent a41901f commit a6b52f1

5 files changed

Lines changed: 542 additions & 107 deletions

File tree

0 commit comments

Comments
 (0)