refactor using delegate (class TerminalCommandProcessor) instead of inheritance#151
Closed
Arnaud-Nauwynck wants to merge 1 commit intofusesource:masterfrom
Closed
refactor using delegate (class TerminalCommandProcessor) instead of inheritance#151Arnaud-Nauwynck wants to merge 1 commit intofusesource:masterfrom
Arnaud-Nauwynck wants to merge 1 commit intofusesource:masterfrom
Conversation
…nheritance (both WindowsAnsiOutputStream/PrintSteam extends AnsiOutputSteam/PrinStream)
hboutemy
added a commit
that referenced
this pull request
Jun 29, 2019
hboutemy
added a commit
that referenced
this pull request
Jun 29, 2019
Collaborator
|
good idea but too complex code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introduce class TerminalCommandProcessor to extract code specific to processing ansi escape commands (currently mixed into AnsiOutputStream, and using override...)
.. so change class inheritance by delegation...(Design Pattern best practices).
.. so also refactor to class WindowsTerminalCommandProcessor extends TerminalCommandProcessor instead of extending both WindowsAnsiOutputStream and WindowsAnsiPrintStream
instead of
AnsiOutputStream AnsiPrintStream <=== lot of Copy&Paste /\ /\ extends extends | | WindowsAnsiOutputStream WindowsAnsiPrintStream <=== also lot of Copy&Pasterefactor as
AnsiOutputStream AnsiPrintStream <==== still lot of Copy&Paste \ / ( ... cf other PR to fix this ) uses uses \ / 1 \/ \/ 1 TerminalCommandProcessor <--- factory --- TerminalType /\ | WindowsAnsiPrintStream