[BUG] GUI: invalid locking of shield notes in coin control

random-zebra · random-zebra · commit d281cde8b374 · 2021-12-02T19:13:03.000+01:00
diff --git a/src/qt/coincontroldialog.cpp b/src/qt/coincontroldialog.cpp
@@ -713,13 +713,16 @@ void CoinControlDialog::loadAvailableCoin(bool treeMode,
     // vout index
     itemOutput->setText(COLUMN_VOUT_INDEX, QString::number(outIndex));
 
-    // disable locked coins
-    const bool isLockedCoin = model->isLockedCoin(txhash, outIndex);
-    if (isLockedCoin) {
-        --nSelectableInputs;
-        coinControl->UnSelect({txhash, outIndex}); // just to be sure
-        itemOutput->setDisabled(true);
-        itemOutput->setIcon(COLUMN_CHECKBOX, QIcon(":/icons/lock_closed"));
+    // disable locked coins (!TODO: implement locked notes)
+    bool isLockedCoin{false};
+    if (fSelectTransparent) {
+        isLockedCoin = model->isLockedCoin(txhash, outIndex);
+        if (isLockedCoin) {
+            --nSelectableInputs;
+            coinControl->UnSelect({txhash, outIndex}); // just to be sure
+            itemOutput->setDisabled(true);
+            itemOutput->setIcon(COLUMN_CHECKBOX, QIcon(":/icons/lock_closed"));
+        }
     }
 
     // set checkbox
