Skip to content

single-image-viewer gesture improvements#272

Merged
ghorbani-m merged 3 commits intofunctionland:developfrom
dhruvtailor7:feature/gallary-image-improvements
Sep 13, 2022
Merged

single-image-viewer gesture improvements#272
ghorbani-m merged 3 commits intofunctionland:developfrom
dhruvtailor7:feature/gallary-image-improvements

Conversation

@dhruvtailor7
Copy link
Copy Markdown
Contributor

@dhruvtailor7 dhruvtailor7 commented Sep 2, 2022

PR for issue #262.

Task

  • Scale down the image while pulling it down for closing
  • Prevent scroll while pulling up the info sheet
  • Hide/show the bottom bar and header when tapping (single tap) on the image

@dhruvtailor7
Copy link
Copy Markdown
Contributor Author

@ghorbani-m Please review the changes.

@ghorbani-m
Copy link
Copy Markdown
Contributor

@ghorbani-m Please review the changes.

Thanks @dhruvtailor7 , will check it out, and let you know.

@ghorbani-m
Copy link
Copy Markdown
Contributor

Great job @dhruvtailor7 ,

  • I've found a dead-lock situation, please have a look at the below video
  • Could you please animate the buttons and header opacity as well (same as the background opacity) while pulling the image down?
WhatsApp.Video.2022-09-06.at.15.46.58.mp4

@ghorbani-m ghorbani-m merged commit 38a6957 into functionland:develop Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants