Skip to content

Move validation from serverless directly into the package#54

Closed
randomhash wants to merge 2 commits into
functionalone:masterfrom
randomhash:master
Closed

Move validation from serverless directly into the package#54
randomhash wants to merge 2 commits into
functionalone:masterfrom
randomhash:master

Conversation

@randomhash

@randomhash randomhash commented Oct 11, 2020

Copy link
Copy Markdown
Collaborator

the package works as expected, tested on live deployments in different cases with default inherit and without.
Resolves #52

Works 2.5.0 +

failing tests with 2.5.0:

  1. first test with common version showing etc.
  2. global role dep, but it is not required and works perfectly at practice.

@coveralls

coveralls commented Oct 12, 2020

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 203

  • 54 of 58 (93.1%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.5%) to 91.441%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/index.ts 54 58 93.1%
Files with Coverage Reduction New Missed Lines %
src/lib/index.ts 2 91.44%
Totals Coverage Status
Change from base Build 128: -1.5%
Covered Lines: 123
Relevant Lines: 132

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin fails starting from Serverless v2.5.0

3 participants