Skip to content

fix: added validate statements#53

Merged
glicht merged 4 commits into
functionalone:masterfrom
andersquist:fix/validate-statements
Oct 31, 2020
Merged

fix: added validate statements#53
glicht merged 4 commits into
functionalone:masterfrom
andersquist:fix/validate-statements

Conversation

@andersquist

@andersquist andersquist commented Oct 11, 2020

Copy link
Copy Markdown
Collaborator

Perhaps not the most elegant of solutions but it will keep this plugin going post version 2.5.0 of Serverless for now I guess.

Be happy to get any feedback.

Closes #52 .

@nkeating-mutualofenumclaw

nkeating-mutualofenumclaw commented Oct 12, 2020

Copy link
Copy Markdown

Any chance we can get these changes out soon? A lot of tools are broken with the latest version of serverless

@andersquist
andersquist force-pushed the fix/validate-statements branch from 51210aa to 172dc55 Compare October 13, 2020 07:41
@coveralls

coveralls commented Oct 13, 2020 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 205

  • 12 of 13 (92.31%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 92.13%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/index.ts 12 13 92.31%
Totals Coverage Status
Change from base Build 128: -0.8%
Covered Lines: 120
Relevant Lines: 128
💛 - Coveralls

@andersquist

andersquist commented Oct 13, 2020

Copy link
Copy Markdown
Collaborator Author

I removed node versions less than 10 in the build matrix since those are versions that Serverless supports these days.

This should now be ready to merge.

@hawkaa

hawkaa commented Oct 13, 2020

Copy link
Copy Markdown

So validation was removed from the original serverless package and now moved in here? Or if it is still in the original serverless package, it changed location?

Also, seems like there is another PR also tackling the issue: #54

@randomhash

randomhash commented Oct 13, 2020

Copy link
Copy Markdown
Collaborator

@hawkaa it is moved out completely
Looks like it is better PR to proceed with, my has bigger updates.
If sls version will be bumped up here, I will close my or, as useless ;)

@hawkaa

hawkaa commented Oct 13, 2020

Copy link
Copy Markdown

Sounds good.

it is moved out completely
If the main package no longer needs validation for the roles and statements, why does this one? It would make sense that they would handle parsing the same way across packages?

@andersquist

andersquist commented Oct 13, 2020

Copy link
Copy Markdown
Collaborator Author

I'll bump it to ^1.80.0 because it is the earliest version of serverless that doesn't fail the test after inverting the global DependsOn check in the tests. Not having the check at all still makes it compatible with version ^1.51.0 afaik and I guess there are still a lot of people out there running older versions...

@Enase

Enase commented Oct 13, 2020

Copy link
Copy Markdown
Collaborator

any chance to get it merged and released?

@jack1902

jack1902 commented Oct 22, 2020

Copy link
Copy Markdown

@randomhash any chance this can be published?

@randomhash

randomhash commented Oct 27, 2020

Copy link
Copy Markdown
Collaborator

@jack1902
Sorry, but I am not the owner of this package, would love to publish

@randomhash randomhash mentioned this pull request Oct 27, 2020
Merged
10 tasks
@glicht
glicht merged commit 09e56ae into functionalone:master Oct 31, 2020
@Enase

Enase commented Nov 2, 2020

Copy link
Copy Markdown
Collaborator

@glicht Any plans to publish new fixed version?

github-actions Bot referenced this pull request in andersquist/serverless-iam-roles-per-function Apr 12, 2022
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
1b31f45 
# [2.1.0](v2.0.2...v2.1.0) (2022-04-12)

### Bug Fixes

* change PermissionsBoundary feature to add  suport for cloudformation functions ([#70](#70)) ([720dc0f](720dc0f))
* **deps:** updated to latest serverless and making tests work ([d0259c8](d0259c8))
* Function properties schema validation fixed ([#63](#63)) ([1f81264](1f81264))
* Support for Serverless v2.5.0 ([#53](#53)) ([09e56ae](09e56ae))

### Features

* add support to PermissionsBoundary ([d68046e](d68046e))
* Docs: added contributing section ([d9715ba](d9715ba))
* nodejs 12 support ([#32](#32)) ([4dd58a2](4dd58a2))
* schema validation ([abbc8af](abbc8af))
* Support new provider.iam property ([6e20297](6e20297)), closes [#73](#73)
* Use resolved region name in counting length of role name ([#33](#33)) ([f9fd677](f9fd677)), closes [#26](#26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@randomhash randomhash randomhash approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Plugin fails starting from Serverless v2.5.0

8 participants

@andersquist @nkeating-mutualofenumclaw @coveralls @hawkaa @randomhash @Enase @jack1902 @glicht