Skip to content

[v2] added signalr#956

Closed
wtmaxim wants to merge 15 commits into
fullstackhero:v2from
wtmaxim:features/v2/add-signalr
Closed

[v2] added signalr#956
wtmaxim wants to merge 15 commits into
fullstackhero:v2from
wtmaxim:features/v2/add-signalr

Conversation

@wtmaxim

@wtmaxim wtmaxim commented Jun 27, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@wtmaxim
wtmaxim marked this pull request as draft June 27, 2024 11:21
@wtmaxim wtmaxim changed the title added signalr [v2] added signalr Jun 27, 2024
@wtmaxim

wtmaxim commented Jun 27, 2024

Copy link
Copy Markdown
Contributor Author

I've done. We can consider adding Redis for message distribution and scalability in a future iteration.

@wtmaxim
wtmaxim marked this pull request as ready for review June 27, 2024 12:42
@iammukeshm

Copy link
Copy Markdown
Member

@wtmaxim could you please resolve the conflicts.

@dsolteszopyn

Copy link
Copy Markdown

Can this be merged now?

Comment thread api/framework/Infrastructure/Notifications/NotificationHub.cs Outdated
@dsolteszopyn

Copy link
Copy Markdown

I've done. We can consider adding Redis for message distribution and scalability in a future iteration.

Need to support redis or azure signalr backplane otherwise can't run in more than one container instance

Comment thread api/framework/Infrastructure/Notifications/NotificationSender.cs Outdated
@wtmaxim

wtmaxim commented Jul 17, 2024

Copy link
Copy Markdown
Contributor Author

I've done. We can consider adding Redis for message distribution and scalability in a future iteration.

Need to support redis or azure signalr backplane otherwise can't run in more than one container instance

I will

@iammukeshm

Copy link
Copy Markdown
Member

Can some usage samples be added for this? We now have the Blazor client ready as well. Atleast from the Products CRUD pov. Can something be added to demonstrate this usage?

@wtmaxim

wtmaxim commented Jul 18, 2024

Copy link
Copy Markdown
Contributor Author

@dsolteszopyn @iammukeshm
Redis done

@iammukeshm

Copy link
Copy Markdown
Member

Hey @wtmaxim , sorry. Forgot about this PR. There is a change in the solution structure now. Whenever you get time, can you resolve these conflicts and let me know. Basically now all the API, Blazor and Aspire Dashboards stay in the same solution file.


SignalRSettings? signalRSettings = configuration.GetSection(nameof(SignalRSettings)).Get<SignalRSettings>();

if (signalRSettings?.UseBackplane == true)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the other way round? Backplane should br false here

}
else
{
var backplaneSettings = configuration.GetSection("SignalRSettings:Backplane").Get<SignalRSettings.Backplane>();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there need to read the setting again here? signalRSettings has the settings

public class Backplane
{
public string? Provider { get; set; }
public string? StringConnection { get; set; }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name? ConnectionString


public class SignalRSettings
{
public class Backplane

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iammukeshm
iammukeshm deleted the branch fullstackhero:v2 July 31, 2024 05:58
@iammukeshm iammukeshm closed this Jul 31, 2024
@maxiar

maxiar commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

@wtmaxim @iammukeshm what about signalR. Why close this PR??????????

Thanks!

@wtmaxim
wtmaxim deleted the features/v2/add-signalr branch November 19, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants