Skip to content

Removed 'Async' word from method names in non async methods#133

Merged
iammukeshm merged 1 commit into
fullstackhero:mainfrom
snax4a:main
Nov 6, 2021
Merged

Removed 'Async' word from method names in non async methods#133
iammukeshm merged 1 commit into
fullstackhero:mainfrom
snax4a:main

Conversation

@snax4a

@snax4a snax4a commented Nov 5, 2021

Copy link
Copy Markdown
Contributor

I removed 'Async' word from method names in non async methods as they were misleading.

@snax4a

snax4a commented Nov 5, 2021

Copy link
Copy Markdown
Contributor Author

@iammukeshm I have a question if you are using any imports sorting extension in your VSCODE?
In vscode settings I had turned on Omnisharp: Organize Imports on Format and Format on Save, which was sorting usings in this way:

using System;
using System.Collections.Generic;
using System.IdentityModel.Tokens.Jwt;
using System.Linq;
using System.Net;
using System.Security.Claims;
using System.Security.Cryptography;
using System.Text;
using System.Threading.Tasks;
using DN.WebApi.Application.Abstractions.Services.General;
using DN.WebApi.Application.Abstractions.Services.Identity;
using DN.WebApi.Application.Exceptions;
using DN.WebApi.Application.Settings;
using DN.WebApi.Application.Wrapper;
using DN.WebApi.Domain.Constants;
using DN.WebApi.Infrastructure.Identity.Models;
using DN.WebApi.Infrastructure.Persistence;
using DN.WebApi.Shared.DTOs.Identity.Requests;
using DN.WebApi.Shared.DTOs.Identity.Responses;
using Microsoft.AspNetCore.Identity;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Localization;
using Microsoft.Extensions.Options;
using Microsoft.IdentityModel.Tokens;

But i saw that you are organizing your usings in this way:

using DN.WebApi.Application.Abstractions.Services.General;
using DN.WebApi.Application.Abstractions.Services.Identity;
using DN.WebApi.Application.Exceptions;
using DN.WebApi.Application.Settings;
using DN.WebApi.Application.Wrapper;
using DN.WebApi.Domain.Constants;
using DN.WebApi.Infrastructure.Identity.Models;
using DN.WebApi.Infrastructure.Persistence;
using DN.WebApi.Shared.DTOs.Identity.Requests;
using DN.WebApi.Shared.DTOs.Identity.Responses;
using Microsoft.AspNetCore.Identity;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Localization;
using Microsoft.Extensions.Options;
using Microsoft.IdentityModel.Tokens;
using System;
using System.Collections.Generic;
using System.IdentityModel.Tokens.Jwt;
using System.Linq;
using System.Net;
using System.Security.Claims;
using System.Security.Cryptography;
using System.Text;
using System.Threading.Tasks;

So my question is if you do it manually or something is helping you to keep that order in whole project?
I turned off my format settings to not mess your convention before making PR.

@iammukeshm
iammukeshm merged commit 6b56a96 into fullstackhero:main Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iammukeshm iammukeshm iammukeshm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@snax4a @iammukeshm