Skip to content

Commit 0ff24d8

Browse files
committed
fix(#6966): declare the example's GitHub token the OpenShell 0.1 way
agents#1513 moved this repository's providers and profiles to declared credentials: the github-ro profile names GH_TOKEN as its api_token, the github-ro provider carries the token, and the _NOOP_ placeholder credentials (the NVIDIA/OpenShell#1978 workaround) are gone. The example still shipped the old shape: undeclared placeholder credentials and no declaration for the token its agent uses. Mirror the repository's copies. `fullsend agent new` does not emit this shape yet (fullsend-ai/fullsend#7883), so the README now names the github-ro pair as the one deliberate difference from generator output, and drops the reference to the closed fullsend-ai/fullsend#6981. Assisted-by: Claude (fix), Claude (review) Signed-off-by: Wayne Sun <[email protected]>
1 parent 2d3e4d2 commit 0ff24d8

4 files changed

Lines changed: 14 additions & 9 deletions

File tree

‎examples/README.md‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,13 @@ while you fill in `agents/my-agent.md`.
7474
which this example was regenerated from — merge that first), and are not
7575
hand-edited here:
7676
they are vendored copies of files that live in fullsend, so a change to one
77-
belongs there, not in this copy. Two of them currently differ from what
78-
fullsend's own scaffold ships, which is tracked as
79-
[fullsend-ai/fullsend#6981](https://github.com/fullsend-ai/fullsend/issues/6981)
80-
and [#7014](https://github.com/fullsend-ai/fullsend/issues/7014).
77+
belongs there, not in this copy. One exception: `providers/github-ro.yaml`
78+
and `profiles/fullsend-github-ro.yaml` declare the GitHub token the
79+
OpenShell 0.1 way this repository's own copies do, which the generator does
80+
not emit yet
81+
([fullsend-ai/fullsend#7883](https://github.com/fullsend-ai/fullsend/issues/7883)).
82+
The generated GitHub profile also lacks the GraphQL endpoint the fleet
83+
profile has
84+
([fullsend-ai/fullsend#7014](https://github.com/fullsend-ai/fullsend/issues/7014)).
8185
- **The prompt is written by hand.** `agents/<name>.md` is the one file the
8286
generator leaves for you, and completing it is the point of the example.

‎examples/link-check/profiles/fullsend-github-ro.yaml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@ id: fullsend-github-ro
33
display_name: Fullsend GitHub (read-only)
44
description: Read-only GitHub API access for fullsend agents
55
category: source_control
6+
credentials:
7+
- name: api_token
8+
description: GitHub token
9+
env_vars: [GH_TOKEN]
10+
required: true
611
endpoints:
712
- host: api.github.com
813
port: 443
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
---
22
name: github-ro
33
type: fullsend-github-ro
4-
# Workaround: https://github.com/NVIDIA/OpenShell/issues/1978
54
credentials:
6-
_NOOP_GITHUB_RO: ""
5+
GH_TOKEN: "${GH_TOKEN}"
Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
11
---
22
name: vertex-ai
33
type: fullsend-vertex-ai
4-
# Workaround: https://github.com/NVIDIA/OpenShell/issues/1978
5-
credentials:
6-
_NOOP_VERTEX_AI: ""

0 commit comments

Comments
 (0)