Skip to content

Commit 25c4dbd

Browse files
author
Félix Therrien
committed
Fixed the matplotlib 3D set_aspect('equal') issue
The NotImplemented error was caused by the fact that set_aspect now causes an error in matplotlib (see matplotlib/matplotlib#1077 and matplotlib/matplotlib#13474). Fixed by making the figure itself square such that the 3D axis are square. Also change the fortan module's name from p2ptrans to fmodules which prevented from importing p2ptrans as a python module.
1 parent 115a52e commit 25c4dbd

2 files changed

Lines changed: 13 additions & 13 deletions

File tree

‎makefile‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ flags = --f90exec=gfortran --f90flags="-fopenmp" --opt=-O3 -lgomp
77

88
#-I/usr/lib64/openmpi/lib/ -L/usr/lib64/openmpi/lib/ -lmpi
99

10-
all: p2ptrans
10+
all: fmodules
1111

12-
p2ptrans: $(files) lap.f90
12+
fmodules: $(files) lap.f90
1313
$(COMP) -c -fPIC lap.f90
1414
$(COMP2) -c $(flags) -I. lap.o -m $@ $(files) only: $(functions)
1515

‎p2ptrans.py‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
from p2ptrans import transform as tr
1+
from fmodules import transform as tr
22
import numpy as np
33
import numpy.linalg as la
44
from mpl_toolkits.mplot3d import Axes3D
55
import matplotlib
66
from matplotlib import animation
7-
from p2ptrans import tiling as t
7+
from fmodules import tiling as t
88
import pickle
99
import time
1010
from pylada.crystal import Structure, primitive, gruber, read, write, supercell, space_group
@@ -15,7 +15,6 @@
1515
from format_spglib import from_spglib, to_spglib
1616
from spglib import get_spacegroup
1717

18-
1918
colorlist=['#929591', 'r', 'k','b','#06470c','#ceb301', '#9e0168', '#26f7fd', '#f97306', '#c20078']
2019
reccolor=['blue','green','red']
2120

@@ -289,6 +288,8 @@ def p2ptrans(fileA, fileB, ncell, filename, display, outdir, use, switch, prim,
289288

290289
import matplotlib.pyplot as plt
291290

291+
plt.rcParams["figure.figsize"] = [5, 5]
292+
292293
import matplotlib.gridspec as gridspec
293294
from matplotlib.patches import Rectangle
294295

@@ -301,7 +302,7 @@ def add_panel(fig,g,plane, state, p, anchor):
301302
ax.set_xlim([-maxXAxis, maxXAxis])
302303
ax.set_ylim([-maxXAxis, maxXAxis])
303304
ax.set_zlim([-maxXAxis, maxXAxis])
304-
ax.set_aspect('equal')
305+
305306
print("ROTATION", set_view(plane))
306307
toplot = set_view(plane).dot(Tpos[state][p])
307308
color_to_plot = np.array(color_array[state][p])
@@ -376,7 +377,7 @@ def all_panels(fig, gs, state, label):
376377
ax.set_xlim([-maxXAxis, maxXAxis])
377378
ax.set_ylim([-maxXAxis, maxXAxis])
378379
ax.set_zlim([-maxXAxis, maxXAxis])
379-
ax.set_aspect('equal')
380+
380381
axlims = [a for b in ax.get_position().get_points() for a in b]
381382
rec = Rectangle((axlims[0],axlims[1]),(axlims[2]-axlims[0]),(axlims[3]-axlims[1]), transform = fig.transFigure, fill=False,lw=3, color="k")
382383
fig.patches.append(rec)
@@ -662,7 +663,7 @@ def PCA(disps):
662663
ax.set_xlim([-maxXAxis, maxXAxis])
663664
ax.set_ylim([-maxXAxis, maxXAxis])
664665
ax.set_zlim([-maxXAxis, maxXAxis])
665-
ax.set_aspect('equal')
666+
666667

667668
# Displacements without stretching (for plotting)
668669
disps_total = Apos_map - Bpos
@@ -674,7 +675,7 @@ def PCA(disps):
674675
ax.set_xlim([-maxXAxis, maxXAxis])
675676
ax.set_ylim([-maxXAxis, maxXAxis])
676677
ax.set_zlim([-maxXAxis, maxXAxis])
677-
ax.set_aspect('equal')
678+
678679
fig.savefig(outdir+'/DispLattice.svg')
679680

680681
# Displacement with stretching
@@ -692,7 +693,7 @@ def PCA(disps):
692693
ax.set_xlim([-maxXAxis, maxXAxis])
693694
ax.set_ylim([-maxXAxis, maxXAxis])
694695
ax.set_zlim([-maxXAxis, maxXAxis])
695-
ax.set_aspect('equal')
696+
696697

697698
def animate(i):
698699
if i<180:
@@ -738,7 +739,7 @@ def init_disps():
738739
ax.set_xlim([-maxXAxis, maxXAxis])
739740
ax.set_ylim([-maxXAxis, maxXAxis])
740741
ax.set_zlim([-maxXAxis, maxXAxis])
741-
ax.set_aspect('equal')
742+
742743
for i in range(len(vec_classes)):
743744
disps_class = disps[:,class_list==i]
744745
ndisps = np.shape(disps_class)[1]
@@ -1002,7 +1003,7 @@ def init_struc():
10021003
ax.set_xlim([-maxXAxis, maxXAxis])
10031004
ax.set_ylim([-maxXAxis, maxXAxis])
10041005
ax.set_zlim([-maxXAxis, maxXAxis])
1005-
ax.set_aspect('equal')
1006+
10061007
fig.savefig(outdir+'/Displacement_structure.svg')
10071008
return fig,
10081009

@@ -1096,7 +1097,6 @@ def init_struc():
10961097
ax.set_xlim([-maxXAxis, maxXAxis])
10971098
ax.set_ylim([-maxXAxis, maxXAxis])
10981099
ax.set_zlim([-maxXAxis, maxXAxis])
1099-
ax.set_aspect('equal')
11001100
fig.savefig(outdir+'/DispLattice_stretched_cell_primitive.svg')
11011101

11021102
plt.show() #TMP

0 commit comments

Comments
 (0)