Skip to content

Commit 6d5b34b

Browse files
authored
version-guard and strict the big exclusive-write xfails, stale since moto 5.1.11 (#1040)
1 parent d3dd9b7 commit 6d5b34b

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

‎s3fs/tests/test_s3fs.py‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3055,10 +3055,13 @@ def test_exist_after_delete(s3):
30553055
# condition: True if running on botocore < 1.36.0
30563056
# The below tests for exclusive writes will fail on older versions of botocore.
30573057
old_botocore = version.parse(botocore.__version__) < version.parse("1.36.0")
3058+
old_moto = version.parse(moto.__version__) < version.parse("5.1.11")
30583059

30593060

30603061
@pytest.mark.xfail(
3061-
reason="moto doesn't support IfNoneMatch for MPU when object created via MPU"
3062+
old_moto,
3063+
reason="moto<5.1.11 doesn't support IfNoneMatch for MPU when object created via MPU",
3064+
strict=True,
30623065
)
30633066
def test_pipe_exclusive_big(s3):
30643067
chunksize = 5 * 2**20 # minimum allowed
@@ -3098,7 +3101,9 @@ def test_pipe_exclusive_big_after_small(s3):
30983101

30993102

31003103
@pytest.mark.xfail(
3101-
reason="moto doesn't support IfNoneMatch for MPU when object created via MPU"
3104+
old_moto,
3105+
reason="moto<5.1.11 doesn't support IfNoneMatch for MPU when object created via MPU",
3106+
strict=True,
31023107
)
31033108
def test_put_exclusive_big(s3, tmpdir):
31043109
chunksize = 5 * 2**20 # minimum allowed

0 commit comments

Comments
 (0)