Repository navigation
Reject position-changing seeks on async HTTP streams - #2214
Merged
martindurant merged 2 commits intoOct 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncStreamFile inherits a seek implementation that updates its logical position, but HTTP streaming reads continue from the same response. A seek therefore appears to work while returning bytes from the wrong offset.
Follow the maintainer's direction in #1772: streaming files should not be seekable. Mirror HTTPStreamFile's no-op seek behavior and ValueError for position-changing seeks, and report seekable() as False. Sequential reads and tell remain consistent; this does not add random-access support or alter other async file implementations.
Tests use the repository's local HTTP server. They cover rejected forward, backward, relative and end-based seeks, allowed no-op seeks, unchanged tell after rejection, and subsequent bytes read from the correct position. Add a changelog entry.
Fixes #1772.