Repository navigation
Report DirFileSystem async support from its backend - #2213
Merged
martindurant merged 1 commit intoOct 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DirFileSystem inherits async_impl=True from AsyncFileSystem even when it wraps a synchronous filesystem. That makes instance capability checks report support the wrapped filesystem does not provide.
Set async_impl on each DirFileSystem instance from its backend, following the direction discussed in #1709. This leaves asynchronous context validation unchanged and keeps True for async backends, including those used through their synchronous interface.
Regression tests cover memory, local and nested directory backends, plus AsyncFileSystemWrapper over memory in both sync and async contexts. They also exercise file reads and writes. Add a changelog entry.
Addresses #1709. This does not change cache filesystem behavior or revise the broader async documentation questions in that issue.
Validation:
Fresh clone with an editable install on Python 3.12: