Repository navigation
Forward local_file through DirFileSystem - #2212
Merged
martindurant merged 2 commits intoOct 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1110.
DirFileSystem wraps a filesystem but does not expose its local_file flag. A directory wrapper around LocalFileSystem therefore fails the local-file check in open_local even though its files are local.
Add a property alongside the existing sep property that reads the wrapped filesystem's local_file flag, defaulting to False when the wrapped filesystem has no flag. This follows the passthrough approach efiop suggested in the issue and martindurant invited a contribution for.
Tests cover local and memory filesystems, nested directory wrappers, an explicit False flag, and open_local's accept/reject checks. The local test opens a real file through OpenFile/OpenFiles. Only URL-to-filesystem construction is substituted so open_local receives the already constructed wrapper.
Verification