Skip to content

Implementation of 'local://' URI Scheme Support#1381

Merged
martindurant merged 5 commits into
fsspec:masterfrom
glesperance:feat/ray-local-paths
Oct 4, 2023
Merged

Implementation of 'local://' URI Scheme Support#1381
martindurant merged 5 commits into
fsspec:masterfrom
glesperance:feat/ray-local-paths

Conversation

@glesperance glesperance changed the title Added support for local:// Implementation of 'local://' URI Scheme Support Sep 29, 2023
@martindurant

Copy link
Copy Markdown
Member

I agree this is useful.

This line should also be updated to be the tuple "file", "local" to make sure we normalise URLs correctly.

@glesperance

Copy link
Copy Markdown
Contributor Author

@martindurant: updated as suggested (e8c7253)

@glesperance

Copy link
Copy Markdown
Contributor Author

@martindurant: updated failing tests

@ap--

ap-- commented Sep 30, 2023

Copy link
Copy Markdown
Contributor

_strip_protocol should be updated too:

@classmethod
def _strip_protocol(cls, path):
path = stringify_path(path)
if path.startswith("file://"):
path = path[7:]
elif path.startswith("file:"):
path = path[5:]
return make_path_posix(path).rstrip("/") or cls.root_marker

@glesperance

Copy link
Copy Markdown
Contributor Author

_strip_protocol should be updated too:

@classmethod
def _strip_protocol(cls, path):
path = stringify_path(path)
if path.startswith("file://"):
path = path[7:]
elif path.startswith("file:"):
path = path[5:]
return make_path_posix(path).rstrip("/") or cls.root_marker

Thanks. Fixed it.

@glesperance

Copy link
Copy Markdown
Contributor Author

@martindurant seems like I had the wrong syntax for the tuple assertion -- this was also fixed. Hopefully we're good to go now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants