More strict installer #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Substitute in F# 3.1 for later versions
…n, this makes it run in fake
Fix ancient build
Added an installation verification step to the startup sequence.
Member
|
Do you know what the idea behind the argument check is? I'm wondering if the else branch is still compatible with these changes if args.Length = 0 then
InstallAndStart(true, true)
else
// Verify kernel installation status
InstallAndStart(false, false)
// Clear the temporary folder
try
if Directory.Exists(Config.TempDir) then Directory.Delete(Config.TempDir, true)
with exc -> Console.Out.Write(exc.ToString())
// adds the default display printers
Printers.addDefaultDisplayPrinters()
// get connection information
let fileName = args.[0]
let json = File.ReadAllText(fileName)
let connectionInformation = JsonConvert.DeserializeObject<ConnectionInformation>(json)
// start the kernel
Kernel <- Some (IfSharpKernel(connectionInformation))
Kernel.Value.StartAsync()
// block forever
Thread.Sleep(Timeout.Infinite) |
Member
|
Ensuring a consistent state with the installer looks like a good change! |
Author
|
The argument check is used to figure out whether I'm being run directly, or by Jupyter. When a kernel is started by Jupyter, it has an argument (the location where to find connection information). Before my change, in this condition it would never validate the installation. It's working correctly for me on either branch, though more testing is welcome. |
Member
|
Makes sense and I see how your safer installation will work better there too. I'd tested it but was curious. I'll merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tightened the installer so that it checks for every static file, and also checks a "version" file, including when the kernel is started from the notebook. Changes to kernel.js to support starting with no config file, equivalent to Colin's (got rid of some replication of paths).