Update to Fable 3#148
Merged
dsyme merged 2 commits intofsprojects:mainfrom Oct 7, 2021
Merged
Conversation
alfonsogarciacaro
force-pushed
the
fable3
branch
2 times, most recently
from
c5fcaee to
9aa780d
Compare
alfonsogarciacaro
force-pushed
the
fable3
branch
from
9aa780d to
35666ed
Compare
Contributor
|
Thank you so much! And I'm deeply impressed with how easy it is to add Fable build and testing. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a remake of #121 and hopefully fixes #145, although I couldn't reproduce the exact error in the issue, tests worked for me first time.
Besides installing latest Fable 3 the only thing I did was removing some
#if FABLE_COMPILERthat shouldn't be needed now and also simplified a bit the npm dependencies in tests/fable.@dsyme I've also updated the pull-request.yml Github workflow to include the fable tests, and also to fix the .NET test command which was still invoking fake. Please let me know if you want me to edit the publish.yml workflow too (btw. I put the "Test Fable" job before the .NET tests because at one point the latter were failing in CI but we can change the order).