Skip to content

Upgrade Fable to Nagareyama#121

Closed
alfonsogarciacaro wants to merge 5 commits intofsprojects:masterfrom
alfonsogarciacaro:nagareyama
Closed

Upgrade Fable to Nagareyama#121
alfonsogarciacaro wants to merge 5 commits intofsprojects:masterfrom
alfonsogarciacaro:nagareyama

Conversation

@alfonsogarciacaro
Copy link
Copy Markdown
Contributor

@alfonsogarciacaro alfonsogarciacaro commented Nov 9, 2020 •
edited
Loading

@Shmew I didn't try it yet but I think with Fable 3 we can get rid of the compiler directives to avoid type testing with generics like:

      #if !FABLE_COMPILER
      match g with
      | :? GenerateCont<'a> as g -> GenerateCont<_>.Bind (g.Generator, (fun () -> GenerateCont<_>.Bind (g.Cont(), cont)))
      | _ -> (new GenerateCont<'a>(g, cont) :> AsyncGenerator<'a>)
      #else

@alfonsogarciacaro alfonsogarciacaro mentioned this pull request Nov 9, 2020
Closed
@mlaily mlaily mentioned this pull request Nov 26, 2020
Closed
@dsyme dsyme closed this Apr 14, 2021
@dsyme dsyme reopened this Apr 14, 2021
@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented Apr 14, 2021

Some problem with #if here

Error: /home/runner/work/FSharp.Control.AsyncSeq/FSharp.Control.AsyncSeq/src/FSharp.Control.AsyncSeq/AsyncSeq.fs(1749,1): error FS0521: No #endif found for #if or #else [/home/runner/work/FSharp.Control.AsyncSeq/FSharp.Control.AsyncSeq/src/FSharp.Control.AsyncSeq/FSharp.Control.AsyncSeq.fsproj]

@dsyme dsyme mentioned this pull request Apr 15, 2021
Merged
@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented Oct 6, 2021

@alfonsogarciacaro I'm closing this, I think it needs to be re-done

@dsyme dsyme closed this Oct 6, 2021
@alfonsogarciacaro alfonsogarciacaro mentioned this pull request Oct 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alfonsogarciacaro @dsyme