fix(Mandatory args): list missing cases#236
Merged
bartelink merged 18 commits intofsprojects:masterfrom Mar 28, 2024
Merged
Conversation
bartelink
changed the title
bartelink
approved these changes
Mar 27, 2024
Member
bartelink
left a comment
bartelink
left a comment
There was a problem hiding this comment.
Thank you for noticing and fixing - can you also add a mention to the release notes please (call it 6.2.3)
Co-authored-by: Ruben Bartelink <[email protected]>
Co-authored-by: Ruben Bartelink <[email protected]>
Co-authored-by: Ruben Bartelink <[email protected]>
Contributor
Author
I have update release note. Minor version because it changes the text of the error message, and display all missing cases |
bartelink
reviewed
Mar 27, 2024
bartelink
reviewed
Mar 27, 2024
bartelink
reviewed
Mar 27, 2024
bartelink
reviewed
Mar 27, 2024
bartelink
reviewed
Mar 27, 2024
bartelink
reviewed
Mar 27, 2024
Co-authored-by: Ruben Bartelink <[email protected]>
Co-authored-by: Ruben Bartelink <[email protected]>
Member
|
Thanks for all the follow-ups and for bearing with all my pedantry. |
Member
|
Released; thanks for another excellent contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regression has occurred in #127
Previously, if a case was missing, help was displayed for the subcommand and not for the main command. This was the same behaviour as when there was an unknown case.
This PR corrects this to restore the old behaviour.
At the same time, the error message when a case is missing has been improved. It used to display only the first missing case.
Now it displays all the missing cases.