fix(ArgumentParser): Correct default programName when run via wrapper#233
Merged
bartelink merged 1 commit intofsprojects:masterfrom Feb 28, 2024
Merged
Conversation
Member
Author
|
This is prompted by me carted along messy code that overrides this for years. I removed my shims recently, having erroneously assumed it was fixed, so I'm proposing this breaking change, for better or worse! If anyone is concerned this is too heavy a change, then I can make a new static method to opt-in, as laid out in #171 (comment) |
nojaf
approved these changes
Feb 28, 2024
Collaborator
nojaf
left a comment
nojaf
left a comment
There was a problem hiding this comment.
I think this is fine to have.
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running via a wrapper such as
dotnetordotnet tool run(see #232 for more of the full scenario), the default logic derives theprogramNameasdotnet, i.e. the exit error message becomes:Another common case of this is that VS in ~2019 used to run in a wrapper, so the message would be correct if you Ctrl-F5 run, but not if you F5-run; who knows if that has changed...