Skip to content

fix: Remove incorrect Dotnet.ReproducibleBuilds ref#202

Merged
bartelink merged 4 commits intofsprojects:masterfrom
bartelink:fix-rb
Dec 13, 2023
Merged

fix: Remove incorrect Dotnet.ReproducibleBuilds ref#202
bartelink merged 4 commits intofsprojects:masterfrom
bartelink:fix-rb

Conversation

@bartelink
Copy link
Copy Markdown
Member

@bartelink bartelink commented Dec 13, 2023

Version 6.1.3 has an incorrect additional reference

Per fsprojects/Paket#2951 this should remove that... Resolved by using a PackageReference rather than fighting paket on this one

@bartelink
Copy link
Copy Markdown
Member Author

bartelink commented Dec 13, 2023

Unfortunately local build still shows it in the nuspec:

<group targetFramework=".NETStandard2.0">
        <dependency id="DotNet.ReproducibleBuilds" version="1.1.1" exclude="Build,Analyzers" />

Hm, is Paket worth it in this repo...

.@nojaf obv not safe to merge yet...

@nojaf
Copy link
Copy Markdown
Collaborator

nojaf commented Dec 13, 2023

I am all ears to remove Paket if that was the question 😅

@bartelink
Copy link
Copy Markdown
Member Author

Yeah, paket is definltely overkill for a small library

I guess my issue is that it could mean time fighting FAKE...

@bartelink
Copy link
Copy Markdown
Member Author

@bartelink bartelink merged commit 4f330d6 into fsprojects:master Dec 13, 2023
@bartelink bartelink deleted the fix-rb branch December 13, 2023 22:45
@bartelink
Copy link
Copy Markdown
Member Author

Seems happy now: https://www.nuget.org/packages/Argu/6.1.4

@bartelink
Copy link
Copy Markdown
Member Author

@sergey-tihon Would you mind unlisting 6.1.3 please (assuming you have the permissions?)

@sergey-tihon
Copy link
Copy Markdown
Member

done

bartelink added a commit to bartelink/Argu that referenced this pull request Feb 19, 2024
* Go behind paket's back
* Bump version to 6.1.4
bartelink added a commit to bartelink/Argu that referenced this pull request Feb 28, 2024
* Go behind paket's back
* Bump version to 6.1.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants