fix: 652 #662
Closed
fix: 652 #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arp242
added a commit
that referenced
this pull request
Mar 31, 2025
inotify_add_watch() follows symlinks, and returns the current watch descriptor when adding a patch twice. So when doing "watch dir" and "watch link" (or reverse) second watch is basically a no-op; yet it's still registered as a "separate" watch, and would panic on removing the second. The solution is to make the second Add() a no-op. This is also what kqueue does, and what happens if you watch the same path twice. On illumos watching a symlink currently means registering double watches; this is a separate bug that should be fixed. Fixes #652 Fixes #662
arp242
added a commit
that referenced
this pull request
Mar 31, 2025
inotify_add_watch() follows symlinks, and returns the current watch descriptor when adding a patch twice. So when doing "watch dir" and "watch link" (or reverse) second watch is basically a no-op; yet it's still registered as a "separate" watch, and would panic on removing the second. The solution is to make the second Add() a no-op. This is also what kqueue does, and what happens if you watch the same path twice. On illumos watching a symlink currently means registering double watches; this is a separate bug that should be fixed. Fixes #652 Fixes #662
arp242
added a commit
that referenced
this pull request
Mar 31, 2025
inotify_add_watch() follows symlinks, and returns the current watch descriptor when adding a patch twice. So when doing "watch dir" and "watch link" (or reverse) second watch is basically a no-op; yet it's still registered as a "separate" watch, and would panic on removing the second. The solution is to make the second Add() a no-op. This is also what kqueue does, and what happens if you watch the same path twice. On illumos watching a symlink currently means registering double watches; this is a separate bug that should be fixed. Fixes #652 Fixes #662
arp242
added a commit
that referenced
this pull request
Mar 31, 2025
inotify_add_watch() follows symlinks, and returns the current watch descriptor when adding a patch twice. So when doing "watch dir" and "watch link" (or reverse) second watch is basically a no-op; yet it's still registered as a "separate" watch, and would panic on removing the second. The solution is to make the second Add() a no-op. This is also what kqueue does, and what happens if you watch the same path twice. On illumos watching a symlink currently means registering double watches; this is a separate bug that should be fixed. Fixes #652 Fixes #662
jakubno
pushed a commit
to e2b-dev/fsnotify
that referenced
this pull request
Jul 31, 2025
inotify_add_watch() follows symlinks, and returns the current watch descriptor when adding a patch twice. So when doing "watch dir" and "watch link" (or reverse) second watch is basically a no-op; yet it's still registered as a "separate" watch, and would panic on removing the second. The solution is to make the second Add() a no-op. This is also what kqueue does, and what happens if you watch the same path twice. On illumos watching a symlink currently means registering double watches; this is a separate bug that should be fixed. Fixes fsnotify#652 Fixes fsnotify#662
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.