macos: retry if open() returns EINTR #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retry the unix.Open() if the error returned is EINTR; looking around the web it seems many systems handle it like this. This is also what os.Open() does: golang/go@50d0ee0 Fixes #354
25 tasks
shogo82148
pushed a commit
to shogo82148/fsnotify
that referenced
this pull request
Mar 6, 2024
port of fsnotify/fsnotify#475 Retry the unix.Open() if the error returned is EINTR; looking around the web it seems many systems handle it like this. This is also what os.Open() does: golang/go@50d0ee0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry the unix.Open() if the error returned is EINTR; looking around the
web it seems many systems handle it like this. This is also what
os.Open() does:
golang/go@50d0ee0
Fixes #354
NOTE: Please do not open a pull request that adds or changes the public API without giving consideration to all supported operating systems.
What does this pull request do?
Where should the reviewer start?
How should this be manually tested?