Skip to content

Run cross-compilation builds on every push #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nshalman merged 1 commit into from
Jan 19, 2022
Merged

Run cross-compilation builds on every push #420

nshalman merged 1 commit into from
Jan 19, 2022

Conversation

@nshalman
Copy link
Contributor

@nshalman nshalman commented Jan 17, 2022

What does this pull request do?

This creates a Github action to run cross-compilation
builds for all supported targets (or at least that's the idea)

This would have caught #389 and should
catch build failures for supported targets.

Where should the reviewer start?

The output of the builds

How should this be manually tested?

N/A

@nshalman
Run cross-compilation builds on every push
74f1d6f 
This would have caught fsnotify#389 and should
catch build failures for supported targets.
@nshalman
Copy link
Contributor Author

nshalman commented Jan 17, 2022

Builds ran in my fork: https://github.com/nshalman/fsnotify/actions/runs/1709688309

@nshalman
Copy link
Contributor Author

nshalman commented Jan 17, 2022 •
edited
Loading

Even on my illumos system I could have caught that (which is why we should run these cross-compilation builds as part of CI):

~/fsnotify $ git checkout v1.5.0 ; GOOS=freebsd GOARCH=amd64 go build
Note: switching to 'v1.5.0'.
<snip>
HEAD is now at 08848a0 v1.5.0 preparation (#380)
# github.com/fsnotify/fsnotify
./kqueue.go:193:43: undefined: unix.O_SYMLINK

@nshalman nshalman requested a review from nathany January 17, 2022 20:12
@nshalman
Copy link
Contributor Author

nshalman commented Jan 17, 2022

I think this PR is a good example of how I intend to maintain quality in this project across all supported platforms. I hope you agree, @nathany.

nathany
nathany approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@nathany nathany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good idea :shipit:

@nshalman nshalman merged commit c11d74b into fsnotify:main Jan 19, 2022
@nshalman nshalman deleted the cross-compile branch January 19, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nathany nathany nathany approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nshalman @nathany