Skip to content

Conversation

@Pratik32
Copy link
Contributor

@Pratik32 Pratik32 commented Oct 7, 2019

What does this pull request do?

Update the FAQ section with supportability of NFS & FUSE filesystems. This is regarding issue #306.

Where should the reviewer start?

The README.md file of the repository,.

How should this be manually tested?

Please suggest if any testing is required for this.

Copy link
Contributor

@nathany nathany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I think this is a little too Linux-specific. Maybe we should generalize the wording?

README.md Outdated
**Why notification does not work with NFS exported filesystems & filesystem in userspace (FUSE)?**

fsnotify requires support from kernel to work.The current NFS kernel driver does not provide network level support for file notfication.
The current linux fuse layer does not have functionality to forward notification events to underlying filesystem.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about macOS? Probably the same limitation, though may need to word differently to cover it?

I'm not sure if FUSE is supported on Windows, so it may not be relevant there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, macOS has the same limitation w.r.t NFS. I will remove the FUSE part & make it more general.

@Pratik32
Copy link
Contributor Author

Pratik32 commented Oct 9, 2019

Hi @nathany , Can you have a look at updated changes.

@nathany
Copy link
Contributor

nathany commented Oct 12, 2019

Thanks

@nathany nathany closed this in 4bf2d1f Oct 12, 2019
@nathany
Copy link
Contributor

nathany commented Oct 12, 2019

Thanks. Merged (with minor revisions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants