Add AddRaw method which does not follow symlinks #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code0x58
force-pushed
the
199-fix
branch
10 times, most recently
from
a74321f to
3891ea9
Compare
Code0x58
changed the title
Code0x58
changed the title
Code0x58
changed the title
nathany
reviewed
Oct 5, 2019
Contributor
nathany
left a comment
nathany
left a comment
There was a problem hiding this comment.
This looks like a good idea. Thanks.
Contributor
|
This would also fix #227. |
nathany
changed the title
Code0x58
force-pushed
the
199-fix
branch
2 times, most recently
from
12ace1d to
8b18300
Compare
Closed
houndci-bot
reviewed
Oct 7, 2019
houndci-bot
reviewed
Oct 7, 2019
houndci-bot
reviewed
Oct 7, 2019
houndci-bot
reviewed
Oct 7, 2019
houndci-bot
reviewed
Oct 7, 2019
Contributor
|
Thanks. And apologies for the delay. We need to sort out that CI issue #373. |
Contributor
Author
|
Here's a PR for migrating away from Travis CI which shows green for master with go 1.11+ #378. I rebased a copy of this branch onto that and the build is green too [test results] |
nathany
previously approved these changes
Aug 2, 2021
nathany
reviewed
Aug 2, 2021
Contributor
|
@Code0x58 I sent you a GitHub invite. Feel free to merge this. Would you be willing to also update the CHANGELOG, AUTHORS, and tag a new release? |
Merged
Contributor
Author
nathany
approved these changes
Aug 18, 2021
This was referenced Aug 23, 2021
ianyh
pushed a commit
to PreVeil/fsnotify
that referenced
this pull request
Jan 19, 2022
* introduce GitHub Actions * Add lint+vet+old versions to GitHub Action * Remove Travis CI and references * Drop support/testing for Go 1.11 and earlier (fsnotify#381) * Update x/sys to latest (fsnotify#379) * add //go:build lines + add 1.17.0-rc2 to test matrix (fsnotify#377) * Update test matrix for go 1.17 stable release (fsnotify#385) * Add AddRaw to not follow symlinks + Fix link folloing on Windows (fsnotify#289) * v1.5.0 preparation (fsnotify#380) * revise pull request template * Revert "Add AddRaw to not follow symlinks + Fix link folloing on Windows (fsnotify#289)" This reverts commit e2e9517. * prepare 1.5.1, retract 1.5.0 * Removed dead link * Update issue templates (fsnotify#410) * Update issue templates * remove old issue template * Test on Go 1.18 and two most recent versions (fsnotify#411) * Test on Go 1.18 and two most recent versions * on push * ci * update readme * revise contributing * maintainers wanted * Final Notice: Maintainers Wanted * fix go vet warnings: call to (*T).Fatalf from a non-test goroutine (fsnotify#416) * made the changes related to recursive directory check * made changes in window.go for buffer size * DA-992: Pair windows' delete + create event to generate a rename event (#1) * made the changes related to recursive directory check * made changes in window.go for buffer size * added the oldname attribute * old name added to rename event, one event is generated for rename * added oldname in printing rename events * tests for checking the oldName attr for rename added * create fsnotify event added * input to create event changed * create fsnotify event function modified * ID added * logs added * added create fsnotify event in inotify * logs added * prints added * reviews * reviews addressed * Hangkun/da 992/window rename event (#2) * Let's begin * Add getpath * Init test workflow * 1.40.0 exits? * Linter fix * asdf * 100 Co-authored-by: hu13 <[email protected]> * Clean up unused * Badge Co-authored-by: Hangkun Ung <[email protected]> Co-authored-by: hu13 <[email protected]> * Rebase upstream fixes * Rename bundle only works on windows * Update CI golang Co-authored-by: Ichinose Shogo <[email protected]> Co-authored-by: Oliver Bristow <[email protected]> Co-authored-by: Nahum Shalman <[email protected]> Co-authored-by: Nathan Youngman <[email protected]> Co-authored-by: Loïc Vernet <[email protected]> Co-authored-by: Nathan Youngman <[email protected]> Co-authored-by: paris <[email protected]> Co-authored-by: hu13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor† change for #199 which on the surface adds a
AddRawmethod to the public interface which does not resolve symlinks before starting a watch.Addmethods to be calledAddRawand not follow symlinksAddmethod which usesfilepath.EvalSymlinks(name)before callingAddRawconsider adding atomic symlink update method(separate issue)A follow on from this would be to offer a high level interface as mentioned on my initial comment for the issue - this can be tracked in a separate issue+PR.
† this does change the behaviour of
Addon windows as it didn't follow symlinks (which do exist) before, but now it does