Skip to content

Consider ignoring CHMOD on Windows #487

@arp242

Description

@arp242

Tilt includes the following change in their fork: main...tilt-dev:fsnotify:main

Windows allows filtering file events to include changes to file
attributes. However, when reporting the actual event, attribute
changes are included as FILE_ACTION_MODIFIED so it's impossible
to distinguish from file writes.

This means the library's op::Chmod is never actually populated
on Windows and so attribute changes aren't really usable. Since
the API does not support specifying an event type filter as a
caller, attribute changes on Windows are ignored rather than being
misreported.

and the README says:

  • [Windows] File attribute changes are ignored
    • No Chmod operations will be detected or returned on Windows because the underlying Windows API does not support
      distinguishing these from Write operations
    • Some software (likely AV/security) can cause excessive attribute changes resulting in many spurious write events
      for otherwise unchanged files

Might want to consider including that here; it seems these events are never useful, and only cause problems. Need to look into it.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions