-
-
Notifications
You must be signed in to change notification settings - Fork 962
Closed
Description
Tilt includes the following change in their fork: main...tilt-dev:fsnotify:main
Windows allows filtering file events to include changes to file
attributes. However, when reporting the actual event, attribute
changes are included asFILE_ACTION_MODIFIEDso it's impossible
to distinguish from file writes.This means the library's
op::Chmodis never actually populated
on Windows and so attribute changes aren't really usable. Since
the API does not support specifying an event type filter as a
caller, attribute changes on Windows are ignored rather than being
misreported.
and the README says:
- [Windows] File attribute changes are ignored
- No
Chmodoperations will be detected or returned on Windows because the underlying Windows API does not support
distinguishing these fromWriteoperations- Some software (likely AV/security) can cause excessive attribute changes resulting in many spurious write events
for otherwise unchanged files
Might want to consider including that here; it seems these events are never useful, and only cause problems. Need to look into it.